I must agree with what most of you said. It's up to the cop at the time. While the law get fuzzy in most states, as in massachusetts it's illegal if you have intent to break the law.
I've been stopped twice while picking locks for friends/family and with proper identification and explaination let off the hook. Each time they warned me they could confiscate the lock picks. Each time I've explained that thier lt. explained to me they are not illegal to carry (grants this often gets them more angry).
While i legally believe they can't take them, unless I am doing something illegal, the sad part is most cops can do what they want. Who is going to believe an 18 year old with no license over a vet. cop? Also, if they were taken away, sure I could fight them and win. Would I want to spend the money? Not unless the cop was a jerk... Takes less than five dollars to make new picks (plus it's a good push to make new picks

)